Glasgow | 26-SDC-July | Mansoor Munawar| Sprint 3 | Implement shell tools - #630
Glasgow | 26-SDC-July | Mansoor Munawar| Sprint 3 | Implement shell tools#630MansoorM11 wants to merge 2 commits into
Conversation
…ty txt file to check my output for wc.mjs
This comment has been minimized.
This comment has been minimized.
MansoorM11
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
MansoorM11
added
the
Needs Review
MansoorM11
changed the title
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start but there is quite a bit of work still to do.
You've built your own argument handling system. Is your way of handling options/arguments always going to be the best? Is there a better way of doing this?
| } | ||
|
|
||
| if (flags.includes("-1")) { | ||
| for (const file of files) { |
There was a problem hiding this comment.
is there a more advanced javascript way of printing each item in an array, so you don't have to write a full for loop?
| } else if (flag === "-c") { | ||
| console.log(getByteCount(content), filePaths); | ||
| } else { | ||
| console.log( |
There was a problem hiding this comment.
When I tested, i got output that looks very different to the original wc app. Can you find a way to make it look more similar?
LonMcGregor
added
Reviewed
MansoorM11
added
Needs Review
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
MansoorM11
added
the
Needs Review
|
The files changed in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the 'files changed' tab at the top of the page. Here is an example of a file that has been changed on this branch but shouldn't be: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
github-actions
Bot
removed
the
Needs Review
2 participants
Self checklist
Changelist
Implemented shell tools such as cat, ls and grep.
Task ID: CYF-1150